Re: [libvirt] PATCH: 0/28: Thread safety for libvirtd daemon and drivers

On Wed, Dec 03, 2008 at 08:20:36PM +0100, Daniel Veillard wrote: > On Wed, Dec 03, 2008 at 06:52:32PM +0000, Daniel P. Berrange wrote: > > On Wed, Dec 03, 2008 at 04:18:21PM +0100, Daniel Veillard wrote: > > > On Mon, Dec 01, 2008 at 12:26:48AM +0000, Daniel P. Berrange wrote: > > > > This is a diffstat summary for the combined series of 28 patches > > > > > > Okay, my take at this point is that those should be commited with > > > the few fix found my manual examination, maybe extend the documentation > > > a bit, and start testing it as much as prossible. > > > Some locking debug facility might be a good addition, > > > > I wrote some an OCaml program using CIL to check driver method exit paths > > and validate that all objects were left in an unlocked state. This found > > some real bugs ! > > > > So here's the incremental fixes for those > [...] > > Damn, I missed them :-) > > Is the CIL code too specific or too limited to share ? I must admit I > looked for a bit on the CIL website and Rich details from his previous > work on it: > http://et.redhat.com/~rjones/cil-analysis-of-libvirt/ > but the Ocaml language barrier somehow blocked me. I started off from Rich's example, and then bashed my head again a brick for 2 days and the attached file is the result :-)