Re: [Libvir] PATCH: Fix dir/fs storage pool when SELinux is disabled
On Mon, Mar 17, 2008 at 05:36:49PM +0100, Jim Meyering wrote:
"Daniel P. Berrange" <berrange(a)redhat.com> wrote:
> When SELinux is disabled fgetfilecon() may well return -1, if a file has no
> extended attribute with security context data. This causes the storage pool
> to skip that file. The fix is to check whether errno is ENODATA and treat
> that as an expected error case & ignore it.
Hi Dan,
That code should handle ENOTSUP as well as ENODATA.
Ok, comitted that too
Dan.
--
|: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|