Re: [libvirt] [PATCHv3] build: avoid -lgcrypt with newer gnutls

On 08/07/2013 07:29 AM, Doug Goldstein wrote: > On Tue, Jul 30, 2013 at 3:45 PM, Eric Blake <eblake(a)redhat.com&gt; wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=951637 >> >> Newer gnutls uses nettle, rather than gcrypt, which is a lot nicer >> regarding initialization. Yet we were unconditionally initializing >> gcrypt even when gnutls wouldn't be using it, and having two crypto >> libraries linked into libvirt.so is pointless, but mostly harmless >> (it doesn't crash, but does interfere with certification efforts). >> >> >> v3: configure logic is enhanced to try harder to get the >> right answer for gentoo. I tested with Fedora 19 and RHEL 6, >> but need feedback from a gentoo tester before this can go in. >> > > I can ACK this by visual code inspection. I haven't explicitly tested > this patch but its a cleaned up version of the patch we previously > discussed it. If you need me to test it, I can do that tonight. I'd feel better with an explicit test; we're in no rush, so I'll wait for your test results on gentoo.