Re: [libvirt] [PATCH 2/2] Ignore backing file errors in FS storage pool (v3)

Currently a single storage volume with a broken backing file will disable the whole storage pool. This can happen when the backing file is on some unavailable network storage or if the backing volume is deleted, while the storage volumes using it are not. Since the storage pool then can not be re-activated, re-creating the missing or deleting the now useless volumes using libvirt only is impossible. To "fix" this case, all errors detected during storage pool activation are now (silently) ignored. Errors are still logged by the called functions, which have more knowledge on the detailed error condition.

diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index ff39d48..0cf4e54 100644 --- a/src/storage/storage_backend_fs.c +++ b/src/storage/storage_backend_fs.c @@ -647,11 +647,11 @@ virStorageBackendFileSystemRefresh(virConnectPtr conn ATTRIBUTE_UNUSED, &vol->allocation, &vol->capacity, &vol->target.encryption)) < 0) { - if (ret == -1) - goto cleanup; - else { - /* Silently ignore non-regular files, - * eg '.' '..', 'lost+found', dangling symbolic link */ + if (ret < 0) { + /* Silently ignore all errors, + * eg '.' '..', 'lost+found', dangling symbolic link, + * backend file unavailable, file unreadable. + * A detailed error report has already been logged. */ virStorageVolDefFree(vol); vol = NULL; continue;