Re: [libvirt] [PATCHv2 1/9] storage: Add new argument for createVol backend API
On 01/16/2014 06:14 AM, Peter Krempa wrote:
The new argument will be used when creating definitions for volumes
that
already exist for the temporary storage volume APIs. The argument will
modify the expectations about the storage files and suppress some error
reports.
---
Notes:
Version 2:
- add commit message lost in a botched rebase
- always initialize volume type for filesystem volumes
VIR_FREE(vol->key);
- return VIR_STRDUP(vol->key, vol->target.path);
+ if (VIR_STRDUP(vol->key, vol->target.path) < 0)
+ return -1;
+
+ return 0;
This changes the result from 1 to 0, but looks safe.
ACK.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)