Re: [libvirt] [PATCHv2] build: fix qemuagenttest build with -O0 in fedora 19.
----- Original Message -----
From: "Eric Blake" <eblake(a)redhat.com>
To: "Jincheng Miao" <jmiao(a)redhat.com>
Cc: libvir-list(a)redhat.com
Sent: Friday, August 2, 2013 4:09:24 AM
Subject: Re: [libvirt] [PATCHv2] build: fix qemuagenttest build with -O0 in fedora 19.
This adds trailing whitespace, and fails 'make syntax-check'. I'm also
surprised that you didn't hit failure with other clients of
libqemumonitortestutils.la, which were also listing libraries in the
wrong order.
Sorry on my careless, I forget to 'make syntax-check'. And it caused by lacking
'$(NULL)'.
---
tests/Makefile.am | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 9c578fa..789de9f 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -417,21 +417,21 @@ qemumonitorjsontest_SOURCES = \
testutils.c testutils.h \
testutilsqemu.c testutilsqemu.h \
$(NULL)
-qemumonitorjsontest_LDADD = $(qemu_LDADDS) libqemumonitortestutils.la
+qemumonitorjsontest_LDADD = libqemumonitortestutils.la $(qemu_LDADDS)
here should be :
+qemumonitorjsontest_LDADD = libqemumonitortestutils.la $(qemu_LDADDS) \
$(NULL)
qemuagenttest_SOURCES = \
qemuagenttest.c \
testutils.c testutils.h \
testutilsqemu.c testutilsqemu.h \
$(NULL)
-qemuagenttest_LDADD = $(qemu_LDADDS) libqemumonitortestutils.la
+qemuagenttest_LDADD = libqemumonitortestutils.la $(qemu_LDADDS)
should be :
+qemuagenttest_LDADD = libqemumonitortestutils.la $(qemu_LDADDS) \
$(NULL)
qemuhotplugtest_SOURCES = \
qemuhotplugtest.c \
testutils.c testutils.h \
testutilsqemu.c testutilsqemu.h \
$(NULL)
-qemuhotplugtest_LDADD = $(qemu_LDADDS) libqemumonitortestutils.la
+qemuhotplugtest_LDADD = libqemumonitortestutils.la $(qemu_LDADDS)
should be:
+qemuhotplugtest_LDADD = libqemumonitortestutils.la $(qemu_LDADDS) \
$(NULL)
domainsnapshotxml2xmltest_SOURCES = \
domainsnapshotxml2xmltest.c testutilsqemu.c testutilsqemu.h \