Re: [libvirt] [PATCH] storage: unify permission formatting
On 12/10/2014 06:00 AM, Martin Kletzander wrote:
Volume and pool formatting functions took different approaches to
unspecified uids/gids. When unknown, it is always parsed as -1, but one
of the functions formatted it as unsigned int (wrong) and one as
int (better). Due to that, our two of our XML files from tests cannot
be parsed on 32-bit machines.
In the past, when we've fixed things like this, we need to make sure
that we can parse both old XML (that used 4294967295) and new XML (that
uses -1). I think you'll need at least one xml2xml test where the input
is old-style and output is new-style, to show that we make the
conversion correctly (and thus, we don't break on upgrade from older style).
RNG schema needs to be modified as well, but because both
storagepool.rng and storagevol.rng need same schema for permission
element, save some space by moving it to storagecommon.rng.
That part makes sense, but I'm not quite ready to ACK without knowing
for sure we are testing it thoroughly.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 539 bytes)