Re: [PATCH v4 3/3] conf: nodedev: Fill active_config at XML parse time

On 4/17/24 17:17, Cole Robinson wrote: > Commit v10.0.0-265-ge67bca23e4 added a `active_config` and > `defined_config` to nodedev mdev internal XML handling. > `defined_config` can be filled at XML parse time, but `active_config` > must be filled in by nodedev driver. This wasn't implemented for the > test driver however, which caused virt-manager test suite regressions. I still think that the mocking of state changes should be handled inside of the test driver itself of the virNodeDeviceDriver in the implementation the interfaces: nodeDeviceCreateXML  => creates a transient mdev from the XML (no persistent config) nodeDeviceDestroy    => removes the active mdev (a transient mdev is completely removed) nodeDeviceDefineXML  => creates a persistent mdev config from the XML nodeDeviceUndefine   => removes the persistent mdev config (if mdev is active the active config remains) nodeDeviceCreate     => creates the active config from the persistent config Therefore for mocking * copy defined_config to active_config * reset defined_config * reset active_config should be sufficient. Since there are only nodeDeviceCreateXML and nodeDeviceDestroy implemented in the test driver the first two should do the trick.