Re: [libvirt] [PATCH] New APIs for checking some object properties
On Wed, Oct 21, 2009 at 01:54:00PM +0200, Daniel Veillard wrote:
> +int virInterfaceIsActive(virInterfacePtr iface);
> +
> +int virConnectIsEncrypted(virConnectPtr conn);
> +int virConnectIsSecure(virConnectPtr conn);
The only small remark I would have is that it's not consistent with
int virDomainGetAutostart (virDomainPtr domain,
int *autostart);
which is also looking at a boolean value. But since we don't expect to
add a way to modify those properties (i.e. no Set operation) I think
it's fine to go with the simpler signature you suggest.
I think the GetAutostart API is rather cumbersome to use as it is :-)
The compelling reason for not doing it though, is that with the syntax
I used in this patch, the python bindings are fully auto-generated.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|