Re: [libvirt] [PATCH v3 12/36] conf: don't pass interface type into virNetDevBandwidthParse
On Fri, Mar 22, 2019 at 11:03:59AM -0400, Laine Stump wrote:
On 3/19/19 8:46 AM, Daniel P. Berrangé wrote:
> The virNetDevBandwidthParse method uses the interface type to decide
> whether to allow use of the "floor" parameter. Using the interface
> type is not convenient as callers may not have that available, but
> still wish to allow use of "floor". Switch to an explicit boolean
> to control its usage.
>
> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
Or we could just always look for floor and parse it, and decide whether or
not it's valid somewhere later in validation. But this definitely doesn't
harm anything, so
Bear in mind that this series is already huge and complicated. Alot of
things in this series had many approaches, and I tended to take the one
that was least disruptive to minimize complexity & risk of this series.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|