Re: [libvirt] [libvirt-TCK][PATCH] use 'raw' format as the format of backing file of qcow2 image

On 04/27/2012 05:15 AM, Eric Blake wrote: > On 02/28/2012 03:38 AM, Guannan Ren wrote: >> If we don't explicitly specify the format of backing file, >> it should use raw by default, if so, libvirt's security drivers >> should *not* grant access to the last.img file& the guest >> should not see the last.img data. That is the purpose of testing. >> --- >> scripts/qemu/205-qcow2-double-backing-file.t | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/scripts/qemu/205-qcow2-double-backing-file.t >> b/scripts/qemu/205-qcow2-double-backing-file.t >> index d3a5e33..ad54c7c 100644 >> --- a/scripts/qemu/205-qcow2-double-backing-file.t >> +++ b/scripts/qemu/205-qcow2-double-backing-file.t >> @@ -114,7 +114,6 @@ SKIP: { >> >> my $volmainxml = $tck->generic_volume("tck-main", "qcow2", >> 1024*1024*50) >> ->backing_file($pathback) >> - ->backing_format("qcow2") >> ->allocation(0)->as_xml; > Just noticing this (sorry for the delay); ACK. > That's great, thanks