Re: [libvirt] [PATCH v2] events: Propose a separate lock for event queue

On Wed, Oct 12, 2011 at 01:58:46PM +0200, Michal Privoznik wrote: > Currently, push & pop from event queue (both server & client side) > rely on lock from higher levels, e.g. on driver lock (qemu), > private_data (remote), ...; This alone is not sufficient as not > every function that interacts with this queue can/does lock, > esp. in client where we have a different approach, "passing > the buck". > > Therefore we need a separate lock just to protect event queue. > > For more info see: > https://bugzilla.redhat.com/show_bug.cgi?id=743817 > --- > src/conf/domain_event.c | 54 ++++++++++++++++++++++++++++++++++++++++------- > src/conf/domain_event.h | 1 + > 2 files changed, 47 insertions(+), 8 deletions(-) > ACK, the locking is correct now. Daniel