Re: [libvirt] [PATCH 4/4] libvirt-guest.init: Use lsb-init functions

On 03/10/2011 10:27 PM, Philipp Hahn wrote: NACK because you dropped the gettext portions. But I completely agree that the standards for init scripts recommend using standard log_* functions rather than direct output to stdout. http://refspecs.freestandards.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-gen... Furthermore, that states that logged messages should be complete lines, no more than 60 characters; I don't know that we can fully comply with that (a uuid takes up a lot of real estate, and we (ab)use \r for progress messages). A proper patch would combine the two approaches - use gettext to perform the translation, then use log_* to output the translated strings. Would you care to rework this patch? Hmm, the Fedora init script standards: http://fedoraproject.org/wiki/Packaging/SysVInitScript which don't mention this file. So we probably ought to make its inclusion conditional, and provide fallback definitions for the log_* functions if it is not present. log_action_msg "$(gettext "libvirt-guests is configured not to start any guests on boot")" merges both translation and proper logging. -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org