Re: [libvirt] [sandbox PATCH 05/11] Image: Refactor create function
On Thu, Jul 23, 2015 at 03:57:31PM +0000, Eren Yagdiran wrote:
Move the docker-related code to the DockerSource and use
the Source mechanism
---
virt-sandbox-image/sources/DockerSource.py | 95 ++++++++++++++++++++++++++++++
virt-sandbox-image/sources/Source.py | 5 ++
virt-sandbox-image/virt-sandbox-image.py | 72 +++++-----------------
3 files changed, 115 insertions(+), 57 deletions(-)
@@ -215,6 +166,11 @@ def requires_source(parser):
default="docker",
help=_("name of the template"))
+def requires_driver(parser):
+ parser.add_argument("-d","--driver",
+ default="qemu:///session",
+ help=_("Type of the driver"))
+
The convention we've adopted with libvirt applications is to
always use -c / --connect to provide the URI. I'd suggest
the URI should default to None, so that we let libvirt choose
the best URI. Using qemu:///session default for example, breaks
when running as root.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|