Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol
On 07/26/2011 07:02 AM, Christoph Hellwig wrote:
I have to say I really hate it. We've been working hard on
getting rid
of special cases in the qemu block layer, and this sprinkles them all
over. I'd recommend to fix your security model instead.
What is it that you hate - the particular qemu implementation expressed
by this patch (in which case, we're all ears for a better
implementation), or the need for fd passing (which libvirt is strongly
in favor of, and which there really is no other way to fix the security
model to work well with file systems like NFS that lack per-file
labels)? In my mind, increased security trumps poor aesthetics - if the
patch really does make it possible to enhance security, then the special
casing to support the patch is worth it.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org