On 08/09/2012 09:20 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
Currently the virNetClientPtr constructor will always register the async IO event handler and the keepalive objects. In the case of the lock manager, there will be no event loop available not keepalive support required. Split this setup out of the
s/not/nor/
constructor and into separate methods.
The remote driver will enable async IO and keepalives, while the LXC driver will only even async IO
s/even/enable/
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/libvirt_private.syms | 2 ++ src/lxc/lxc_monitor.c | 2 ++ src/remote/remote_driver.c | 9 ++++++ src/rpc/virnetclient.c | 81 ++++++++++++++++++++++++++++++---------------- src/rpc/virnetclient.h | 3 ++ 5 files changed, 69 insertions(+), 28 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index e3d31dc..78d944f 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1320,6 +1320,8 @@ virNetClientNewExternal; virNetClientNewSSH; virNetClientNewTCP; virNetClientNewUNIX; +virNetClientRegisterASyncIO;
We have 236 instances of 'Async' in the code base, and 0 instances of 'ASync' prior to this. I thin you want s/ASync/Async/g throughout the patch. ACK with that change. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org