Re: [libvirt] PATCH: Fix some more memory leaks

"Daniel P. Berrange" <berrange(a)redhat.com&gt; wrote: > While testing Cole's series of patches I identified a couple more places > where we leak memory. > > In libvirt.c, the default authentication callback uses uninitialized > data, and indeed strdup()'s it and this is then never released. This > simply disables that bit of code. > > In qparams.c when free'ing the struct the 'p' struct field was not > released. I took the opportunity to switch it over to using the new > style memory.h functions > > In remote.c there were a couple of handlers which forgot to free the > virDomainPtr object when they were done. > > qemud/remote.c | 18 ++++++++++++++---- > src/libvirt.c | 16 +++++++++------- > src/qparams.c | 31 +++++++++++++------------------ > 3 files changed, 36 insertions(+), 29 deletions(-) Looks good. I suppose the tests that exposed the leaks aren't yet run as part of "make check". It'd be nice...