Re: [libvirt] [PATCH 3/8] Implement virDomain{Set, Get}BlockIoTune for the qemu driver

On 11/15/2011 02:02 AM, Lei Li wrote: 'make syntax-check' didn't like this one: libvirt_unmarked_diagnostics src/qemu/qemu_monitor_json.c-3332- ), "total_bytes_sec"); src/qemu/qemu_monitor_json.c-3338- ), "read_bytes_sec"); src/qemu/qemu_monitor_json.c-3344- ), "write_bytes_sec"); src/qemu/qemu_monitor_json.c-3350- ), "total_iops_sec"); src/qemu/qemu_monitor_json.c-3356- ), "read_iops_sec"); src/qemu/qemu_monitor_json.c-3362- ), "write_iops_sec"); maint.mk: found unmarked diagnostic(s) I ended up shuffling those lines around. Also, prohibit_empty_lines_at_EOF src/qemu/qemu_monitor_json.c src/qemu/qemu_monitor_text.c maint.mk: empty line(s) or no newline at EOF I stripped the spurious whitespace. Naming should match the public API. After fixing the syntax errors, I then got: qemu/qemu_driver.c: In function 'qemuDomainSetBlockIoTune': qemu/qemu_driver.c:10881:34: error: 'virDomainDiskDef' has no member named 'blkdeviotune' Ouch - your patches are submitted out of order. Looks like I'll have to defer further review of this one until domain_conf.h is updated. -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org