Re: [libvirt] [PATCH] virsh: Print error message if argument parsing fails for cmdNodesuspend

On 12/13/2011 03:24 PM, Peter Krempa wrote: >> Compilation without NLS will trigger gcc warnings that you are using a >> printf-style interface without any %. Write this as vshError(ctl, "%s", >> _("Invalid target argument")). >> > > Oh! Now I understand why there's used notation "%s", "some const string" > throughout virsh. I wish we could get gcc to warn even when compiling with NLS. clang also issues the warnings about a constant format string, regardless of whether NLS is enabled, but we don't compile under clang as often.