3 Mar
2008
3 Mar
'08
12:12 p.m.
Daniel Veillard <veillard@redhat.com> wrote:
On Mon, Mar 03, 2008 at 11:50:30AM +0100, Jim Meyering wrote:
Daniel Veillard <veillard@redhat.com> wrote: ... Thanks for the quick feedback.
Okay, i would have checked caps->host.nmigrateTrans against NULL first
If I were to do that, "make distcheck" would detect the redundant if-before-free and make the build fail.
My point is that if you access caps->host.migrateTrans[i] then you should make sure caps->host.migrateTrans is not NULL,
That's ok because it's guarded by nmigrateTrans > 0, which is true IFF migrateTrans is non-NULL -- see virCapabilitiesAddHostMigrateTransport.