Re: [libvirt] Patch replaces scriptlets with new systemd macros

On 10/24/2012 04:37 AM, Václav Pavlín wrote: Upstream, we would want to patch libvirt.spec.in (the parent of libvirt.spec). This is a downstream-only change, since upstream libvirt.spec.in does not track downstream releases. Besides, downstream is more likely to use the upstream v0.10.2-maint branch and use 0.10.2.1-1 as the next build for Fedora 18. Hmm - we may have a pre-existing issue: this is a case of enabling a service that we don't own, but where cgconfig.service is a prerequisite of libvirtd.service. Is this really the right order for enabling the two services, and is it really necessary for use to explicitly enable cgconfig.service, or should the contents of libvirtd.service be adequate for systemd to automatically figure out the dependency? Again, %changelog is something only needed for downstream builds. Also, your patch is missing a conversion for libvirt-guests.service, also in the spec file: $ grep -C2 libvirt-guests.service libvirt.spec.in # If the package is allowed to autostart: /bin/systemctl --no-reload enable libvirt-guests.service >/dev/null 2>&1 ||: # Run these because the SysV package being removed won't do them /sbin/chkconfig --del libvirt-guests >/dev/null 2>&1 || : /bin/systemctl try-restart libvirt-guests.service >/dev/null 2>&1 || : %endif -- %{_sysconfdir}/rc.d/init.d/libvirt-guests %if %{with_systemd} %{_unitdir}/libvirt-guests.service %endif %config(noreplace) %{_sysconfdir}/sysconfig/libvirt-guests -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org