Re: [libvirt] [PATCH] qemu: Remove unnecessary variable assignment
I understand. Thanks for your reminding.
2013/9/6 Ján Tomko <jtomko(a)redhat.com>
On 09/06/2013 07:35 AM, Hongwei Bi wrote:
> Remove unnecessary 'addrs = NULL' in
> qemuDomainAssignS390Addresses() and
> qemuDomainAssignPCIAddresses() due to
> the related Free function in label cleanup.
But it is necessary, because we assign the value of addrs to
priv->ccwaddrs.
If we didn't set addrs to NULL, it would get freed by that function in the
cleanup: section and priv->ccwaddrs would point to freed memory.
Jan
Attachments:
- attachment.html (text/html — 1.1 KB)