Re: [libvirt] [PATCH] esx: Add read-only storage pool access

On Fri, May 07, 2010 at 10:02:53PM +0200, Matthias Bolte wrote: > Add VIR_STORAGE_POOL_INACCESSIBLE to denote a running but inaccessible > storage pool. For example an NFS pool is inaccessible when the NFS > server is currently unreachable. > > Add CIFS to the list of network file systems because ESX distinguishes > between NFS and CIFS. ACK to these two additions since they're trivial.

> > Alter the esxVI_ProductVersion enum in a way that allows to check for > product type by masking. > > Make esxVI_*_CastFromAnyType dynamically dispatched in order to handle > the DatastoreInfo type and inheriting types properly. > > Allow esxVI_X_DynamicCast to be called successfully on objects with > type X. This is necessary for handling DatastoreInfo and inheriting > types properly. > --- >  include/libvirt/libvirt.h.in   |    1 + >  po/POTFILES.in                 |    1 + >  src/conf/storage_conf.c        |    2 +- >  src/conf/storage_conf.h        |    1 + >  src/esx/esx_storage_driver.c   |  606 +++++++++++++++++++++++++++++++++++++++- >  src/esx/esx_vi.c               |  126 ++++++++- >  src/esx/esx_vi.h               |   26 ++- >  src/esx/esx_vi_generator.input |   59 ++++ >  src/esx/esx_vi_generator.py    |   20 ++- >  src/esx/esx_vi_types.c         |   44 ++- >  tools/virsh.c                  |    4 + >  11 files changed, 845 insertions(+), 45 deletions(-) The patch generally looks ok to me - I've not comments to add beyond what Eric raised. Daniel