Re: [libvirt] [PATCH] Fix failing virGetHostname.

On 05/20/2010 03:57 PM, Chris Lalancette wrote: > We've been running into a lot of situations where > virGetHostname() is returning "localhost", where a plain > gethostname() would have returned the correct thing. This > is because virGetHostname() is *always* trying to canonicalize > the name returned from gethostname(), even when it doesn't > have to. > > This patch changes virGetHostname so that if the value returned > from gethostname() is already FQDN or localhost, it returns > that string directly. If the value returned from gethostname() > is a shortened hostname, then we try to canonicalize it. If > that succeeds, we returned the canonicalized hostname. If > that fails, and/or returns "localhost", then we just return > the original string we got from gethostname() and hope for > the best. > > Note that after this patch it is up to clients to check whether > "localhost" is an allowed return value. The only place > where it's currently not is in qemu migration. > > Signed-off-by: Chris Lalancette <clalance(a)redhat.com&gt; Hmm, why isn't one of the fallback options: if (conn) hostname = parse_uri(conn.get_uri()) if hostname != "localhost": return hostname Seems like if MigratePrepare2 dconn is the remote connection, we are guaranteed to have a resolvable hostname in the URI (well, resolvable to the source connection at least).