Re: [libvirt] [PATCH 2/2] qemu: Don't fail if the SCSI host device is shareable between domains
On 01/17/2014 02:06 AM, Osier Yang wrote:
<...snip...>
As a conclusion, I think the only concern from you is about the problem
on the running domain of an old libvirt (without these 2 patches). Right?
If so, my thought is to add document somewhere, though I have not
much idea about where to put the document, and how to write the
document to explain the problem which is such complicated.
Just trying to think and reason through the possibilities to help make
sure we're on the same page and reduce the chance for possible future
corner case issues...
With regard to the error message - just a way to indicate that the
failure was due to the device not being set shareable should be fine.
Whether that's "this" domain hasn't set it shareable or
"another" domain
hasn't set it shareable is a "nice" addition. Just saying already in use
doesn't give enough of a hint that perhaps there is a way or for what
reason we failed. Of course reading the code it's easy, but if you're a
customer without code...
Finally - I think a note in the Device section of formatdomain.html to
indicate when support was really added. Sure the tag was added in 1.0.6,
but it's not really functional until 1.2.2. Not sure how best to say
that other than perhaps changing the since value... In the same area it
should be noted that all domains using/defining the device need to have
the shareable tag; otherwise, depending on order of domain startup one
or more domains will fail to start.
John