Re: [libvirt PATCH v2] Revert "cgroup/LXC: Do not condition availability of v2 by controllers"

On Tue, Oct 25, 2022 at 01:13:44PM +0100, Daniel P. Berrangé wrote: > On Tue, Oct 25, 2022 at 01:46:22PM +0200, Michal Prívozník wrote: > > On 10/25/22 13:43, Pavel Hrdina wrote: > > > This reverts commit e49313b54ed2a149c71f9073659222742ff3ffb0. > > > This reverts commit a0f37232b9c4296ca16955cc625f75eb848ace39. > > > > > > Revert them together to not break build. > > > > > > This fix of the issue is incorrect and breaks usage of other controllers > > > in hybrid mode that systemd creates, specifically usage of devices and > > > cpuacct controllers as they are now assumed to be part of the cgroup v2 > > > topology which is not true. > > > > > > We need to find different solution to the issue. > > > > > > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > > > --- > > > src/util/vircgroup.c | 6 ++---- > > > src/util/vircgroupv2.c | 15 +++++++++++++++ > > > 2 files changed, 17 insertions(+), 4 deletions(-) > > > > > > Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > > > > This brings me back to my original proposal - let's forget that hybrid > > mode exist and aim on v1 or v2, solely. > > FWIW, I thought that was already our intention. It has been recommended > to me by systemd maintainers that hybrid mode is best ignored. The issue is that on systemd based distributions where you have v1 only it is technically hybrid setup where systemd uses v2 without any controller enabled for process tracking and that's the root cause of the issue that the original patch wanted to address.