Re: [libvirt] [PATCH sandbox v5 07/20] Image: Refactor create function

On Tue, 2015-09-08 at 17:29 +0100, Daniel P. Berrange wrote: > From: Eren Yagdiran <erenyagdiran(a)gmail.com&gt; > > Move the docker-related code to the DockerSource and use > the Source mechanism > > Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; > --- > libvirt-sandbox/image/cli.py | 76 +++++----------------- > libvirt-sandbox/image/sources/DockerSource.py | 90 +++++++++++++++++++++++++++ > libvirt-sandbox/image/sources/Source.py | 15 +++++ > 3 files changed, 122 insertions(+), 59 deletions(-) >

> + def _extract_tarballs(self,directory,format,connect): > + tempdir = "/mnt" Is it safe to assume we'll be able to use /mnt as a temporary mount folder? I'ld be more inclined in using a really temporary folder.

-- Cedric > + tarfile = directory + "tar.gz" > + diskfile = directory + "qcow2" > + cmd = ['virt-sandbox'] > + if connect is not None: > + cmd.append("-c") > + cmd.append(connect) > + cmd.append("-p") > + params = ['-m', > + 'host-image:/mnt=%s,format=%s' %(diskfile,format), > + '--', > + '/bin/tar', > + 'zxf', > + '%s' %tarfile, > + '-C', > + '/mnt'] > + cmd = cmd + params > + subprocess.call(cmd) > + > def debug(msg): > sys.stderr.write(msg)