Re: [libvirt] [PATCH 4/5] virinitctl: Expose fifo paths and allow caller to chose one

On Fri, Jan 25, 2019 at 02:31:48PM +0100, Michal Privoznik wrote: > So far the virInitctlSetRunLevel() is fully automatic. It finds > the correct fifo to use to talk to the init and it will set the > desired runlevel. Well, callers (so far there is just one) will > need to inspect the fifo a bit just before the runlevel is set. > Therefore, expose the internal list of fifos and also allow > caller to explicitly use one. > > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > --- ... > -int virInitctlSetRunLevel(virInitctlRunLevel level); > + > +extern const char *virInitctlFifos[3]; I prefer [] to prevent compiler from complaining if someone adds a new fifo

> + > +int virInitctlSetRunLevel(const char *fifo, > + virInitctlRunLevel level); > > #endif /* LIBVIRT_VIRINITCTL_H */ > -- Reviewed-by: Erik Skultety <eskultet(a)redhat.com&gt;