Re: [PATCH] libxl: Implement domainGetMessages API

On Mon, Dec 13, 2021 at 17:35:36 -0700, Jim Fehlig wrote: > Since commit 46783e6307a, the 'virsh dominfo' command calls > virDomainGetMessages to report any messages from the domain. > Hypervisors not implementing the API now get the following > log message when clients invoke 'virsh dominfo' > > this function is not supported by the connection driver: virDomainGetMessages > > Although libxl currently does not support any tainting or > deprecation messages, provide an implementation to squelch > the previously unseen error message when collecting dominfo. So you are fixing a symptom, but IMO the proper fix is to just make virsh ignore errors when virDomainGetMessages is not supported. I have nothing against the code itself, but I wouldn't describe it as a fix for virsh showing an error.