[libvirt] 答复: [PATCH 0/3] virSysinfo: Introduce SMBIOS type 3 support

-----邮件原件----- 发件人: John Ferlan [mailto:jferlan@redhat.com] 发送时间: 2018年2月14日 22:02 收件人: Zhuangyanying <ann.zhuangyanying(a)huawei.com>; libvir-list(a)redhat.com; berrange(a)redhat.com 抄送: Zhangbo (Oscar) <oscar.zhangbo(a)huawei.com>; Gonglei (Arei) <arei.gonglei(a)huawei.com>; Jiangyifei <jiangyifei(a)huawei.com&gt; 主题: Re: [libvirt] [PATCH 0/3] virSysinfo: Introduce SMBIOS type 3 support On 02/14/2018 04:22 AM, Zhuangyanying wrote: > From: Zhuang Yanying <ann.zhuangyanying(a)huawei.com&gt; > > Some applications inside VM need to access SMBIOS Chassis Asset Tag, > which should be emulated. > > access inside VM (for example) > Linux: /sys/class/dmi/id/chassis_asset_tag. > Windows: (Get-WmiObject Win32_SystemEnclosure).SMBIOSAssetTag > wirhin Windows PowerShell. > > It has already been realized in qemu: > > SMBIOS: Build aggregate smbios tables and entry point > https://git.qemu.org/?p=qemu.git;a=commit;h=c97294ec1b9e36887e119589d 456557d72ab37b5 > > but not in libvirt. we realize it here. > As an example, you could use something like > > <chassis> > <entry name='manufacturer'>Huawei</entry> > <entry name='version'>To be filled by O.E.M.</entry> > <entry name='serial'>To be filled by O.E.M.</entry> > <entry name='asset'>To be filled by O.E.M.</entry> Would prefer some more "realistic values" rather than "To be filled by O.E.M."... They don't have to be exactly what is on your system, but closer to expectations would be nice. Similar to what already exists. You can just respond here and I can make the changes for you.

NB: The xml files you put in patch2 should have been in patch1 - I can move those too.

Other than that everything looks good to me. John > <entry name='sku'>Type3Sku1</entry> > </chassis> > > BTW: I'll be on vacation for china spring festival for the next week, I'll response as soon as I get back if there's any modification needed. > > Zhuang Yanying (3): > conf: add support for setting Chassis SMBIOS data fields > qemu: add support for generating SMBIOS Chassis strings command line > news: add support for setting Chassis SMBIOS data fields > > docs/formatdomain.html.in | 23 +++++++ > docs/news.xml | 5 ++ > docs/schemas/domaincommon.rng | 22 ++++++ > src/conf/domain_conf.c | 55 +++++++++++++++ > src/libvirt_private.syms | 1 + > src/qemu/qemu_command.c | 51 ++++++++++++++ > src/util/virsysinfo.c | 133 +++++++++++++++++++++++++++++++++++- > src/util/virsysinfo.h | 13 ++++ > tests/qemuxml2argvdata/smbios.args | 2 + > tests/qemuxml2argvdata/smbios.xml | 7 ++ > tests/qemuxml2xmloutdata/smbios.xml | 7 ++ > 11 files changed, 318 insertions(+), 1 deletion(-) >