Re: [libvirt] [PATCH v2] libvirtd: clarify the TLS conf default vaule setting
On Fri, Jan 19, 2018 at 05:20:10PM -0500, John Ferlan wrote:
[...]
More simply stated:
Provide more details related to the requirement that setting one
of the values requires setting all of them.
Sounds clearer.
[...]
How about this instead:
# Use of TLS requires that x509 certificates be issued. The default locations
# for the certificate files is as follows:
#
# /etc/pki/CA/cacert.pem - The CA master certificate
# /etc/pki/libvirt/servercert.pem - The server certificate signed with
# the cacert.pem
# /etc/pki/libvirt/private/serverkey.pem - The server private key
#
# It is possible to override the default locations by altering the 'key_file',
# 'cert_file', and 'ca_file' values and uncommenting them below.
#
# NB, overriding the default of one location requires uncommenting and
# possibly additionally overriding the other settings.
#
Noticed this change randomly. The above looks much better to me. So,
if we go with the above:
Reviewed-by: Kashyap Chamarthy <kchamart(a)redhat.com>
--
/kashyap