Re: [libvirt] [PATCH] Add support for DNS TXT records
On 03/29/2011 06:52 AM, Michal Novotny wrote:
[snip]
So I guess we should disable the spaces in the name since it's being
interpreted like \032 characters as can be seen in the dig output - we
should either disable such a definition entirely or change spaces (' ')
to dashes ('-'). But escaping the value of the record to the quotes is a
good thing since this is working fine.
I think giving an error on an illegal character is a better idea than
silently changing it to something else. If it's not supported, it's not
supported; the admin should be made aware of that, and manually change
it to something that is allowed.
So what do you think about this? Also, do you think we should
implement
everything connected to DNSMasq mentioned there (i.e. both DNS and DHCP
stuff) in one commit, just few separate patches (e.g. one for DNS and
second for DHCP/BOOTP) ?
Sorry - you're moving much too fast for me to keep up! :-)
I think it's a good idea for your patch to just cover DNS-related items,
and we can put the others into a different patch.