Re: [libvirt] [PATCH 3/3] qemu: Don't skip detection of virtual cpu's on non KVM targets
On 05/11/2012 01:12 AM, Eric Blake wrote:
On 05/07/2012 06:16 AM, Peter Krempa wrote:
> QEMU adapted the info cpus command from the kvm branch. This patch
> removes the check for the KVM domain type to detect virtualprocessors
> also while using software emulation.
Which version of qemu adopted the command? Do we need a capability bit
in qemu_capabilities.h to track whether the command exists and will be
reliable enough?
The thread_id field was initialy added in the kvm fork of qemu and is
present in the 0.12 version. Upstream qemu bacported this functionality
in v0.15. Before 0.15 only the program counter was printed.
I had to modify the patch (It's no longer pure deletion :-( ) to cope
with this in a (hopefuly)-all-version-compatible(TM) manner.
I'll post v2 soon.
Peter
>
> The output of the "info cpus" command may vary across different targets
> but informations that are parsed by libvirt (cpu ID and thread pid) are
s/informations that are/information that is/
> (should be) present on those other targets too.
> ---
> src/qemu/qemu_process.c | 12 ------------
> 1 files changed, 0 insertions(+), 12 deletions(-)
>
Bug fix by deletion is always fun, but are we sure this works with, for
example, non-kvm qemu 0.12?