Re: [libvirt] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm
On Mon, Sep 22, 2014 at 12:42:47PM +0100, Daniel P. Berrange wrote:
On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote:
> On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
> > Add a configure option --enable-pc-1-0-qemu-kvm and the
> > corresponding --disable-pc-1-0-qemu-kvm, defaulting
> > to disabled.
> >
> > Rename machine type pc-1.0 to pc-1.0-qemu-git.
> >
> > Make pc-1.0 machine type an alias of either pc-1.0-qemu-kvm
> > or pc-1.0-qemu-git depending on the value of the config
> > option.
> >
> > Signed-off-by: Alex Bligh <alex(a)alex.org.uk>
>
> I have to say, this one bothers me.
> We end up not being able to predict what does pc-1.0
> reference.
Yeah, this is not good. Any single machine type name should have
fixed semantics - having two different semantics depending on build
options means mgmt apps can no longer simply compare the machine
type name to determine if it is a match with the same name on a
different host.
Regards,
Daniel
Right. However, the fact remains that distros shipped qemu
and qemu-kvm that had pc-1.0 meaning different things.
What do you think about my idea to detect the meaning
for pc-1.0 based on argv[0]?