Re: [libvirt] [PATCH] node_device: Check return value for udev_new()

On Wed, Nov 30, 2016 at 01:45:32PM +0100, Marc Hartmayer wrote: > The comment was actually wrong as > https://www.freedesktop.org/software/systemd/man/udev_new.html > mentions that on failure NULL is returned. > > Signed-off-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com&gt; > Reviewed-by: Bjoern Walk <bwalk(a)linux.vnet.ibm.com&gt; > Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com&gt; > --- > src/node_device/node_device_udev.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c > index 4b81312..4b0a875 100644 > --- a/src/node_device/node_device_udev.c > +++ b/src/node_device/node_device_udev.c > @@ -1491,13 +1491,11 @@ static int nodeStateInitialize(bool privileged, > if (udevPCITranslateInit(privileged) < 0) > goto cleanup; > > - /* > - * http://www.kernel.org/pub/linux/utils/kernel/hotplug/libudev/libudev-udev... > - * > - * indicates no return value other than success, so we don't check > - * its return value. > - */ > udev = udev_new(); > + if (!udev) { > + virReportOOMError(); > + goto cleanup; > + } Is that true for other udevs and not just systemd-udev? Does it really mean just an OOM error? Couldn't we add a proper error message?