Re: [PATCH 1/1] domain_conf.c: skip checking ZPCI address is incomplete if not present
On 6/27/20 10:32 AM, Andrea Bolognani wrote:
On Fri, 2020-06-26 at 18:49 -0300, Daniel Henrique Barboza wrote:
> Commit 076591009ad1 ("conf: fix zPCI address auto-generation on
> s390") is doing a check for virZPCIDeviceAddressIsIncomplete()
> prior to checking if the device has a ZPCI address at all. This
> results in errors like these when starting Libvirt:
>
> error : virDomainDeviceInfoFormat:7527 : internal error:
> Missing uid or fid attribute of zPCI address
>
> Fix it by moving virZPCIDeviceAddressIsIncomplete() after the
> check done by virZPCIDeviceAddressIsPresent().
>
> Fixes: 076591009ad11ec108521b52a4945d0f895fa160
> CC: Bjoern Walk <bwalk(a)linux.ibm.com>
> CC: Boris Fiuczynski <fiuczy(a)linux.ibm.com>
> CC: Shalini Chellathurai Saroja <shalini(a)linux.ibm.com>
> CC: Andrea Bolognani <abologna(a)redhat.com>
> Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com>
> ---
> src/conf/domain_conf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Good catch!
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
and pushed with an ever so slightly tweaked commit message.
In the future, please don't include CC tags in your commits: removing
them results in extra work when picking up a patch, and it's also
generally not considered very polite to CC individual developers.
Everyone is subscribed to the list anyway :)
I screwed up with the CC: tags in the commit msg. I usually do it via
"--cc" in git-sendpatch in these cases.
As for not being polite, I CC'ed the people that was related with the
commit that I was fixing (signed-off/reviewed-by). Perhaps I should
have CC'ed just the author instead .... assuming that CC'ing the author
of the commit I'm amending is OK here in Libvirt, of course. At least
in the QEMU mailing list it's not just OK, but encouraged to CC the
author of the commit you're fixing to make the person aware.
Thanks,
DHB