Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

On Fri, Jun 22, 2018 at 14:55:02 +0200, Kevin Wolf wrote: > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: >> >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: >>> The -drive option serial was deprecated in QEMU 2.10. It's time to >>> remove it. >>> >>> Tests need to be updated to set the serial number with -global instead >>> of using the -drive option.

>> So it seems that this breaks s390x. > > Thanks for bringing this up. libvirt should fix this before QEMU 3.0 is > released. So, I already extracted the code that formats the attributes which should be actually done for the frontend few months ago, but did not swithc to it since I did not want to check when everything was added. The fix will be rather simple if we are certain that the disk serial, geometry and error policies were supported in qemu 1.5. In that case we can switch unconditionally to the new format.