Re: [libvirt] [PATCHv3 2/3] v8.2 add support for DHCPv6

> diff --git a/src/util/dnsmasq.c b/src/util/dnsmasq.c > >index 4f210d2..8f26d42 100644 > >--- a/src/util/dnsmasq.c > >+++ b/src/util/dnsmasq.c > >@@ -306,7 +306,14 @@ hostsfileAdd(dnsmasqHostsfile *hostsfile, > > if (!(ipstr = virSocketAddrFormat(ip))) > > return -1; > > > >- if (name) { > >+ /* the first test determins if it is a dhcpv6 host */ s/determins/determines/ And is that actually true? I thought you could have ipv4 static hosts based on name as well. You should instead check the FAMILY of the address that is passed in. > >+ if (mac==NULL) { > >+ if (virAsprintf(&hostsfile->hosts[hostsfile->nhosts].host, "%s,[%s]", > >+ name, ipstr) < 0) { > >+ goto alloc_error; > >+ } > >+ } > >+ else if (name) { > > if (virAsprintf(&hostsfile->hosts[hostsfile->nhosts].host, "%s,%s,%s", Hmm, but according to this just giving name and IP for IPv4 would blow up in your face... Can you ask about this on dnsmasq list (or verify in the code)? If name+ip-only is allowed for IPv4, we need to change the hostsfileAdd function, and if not, we need to change the parse to always require a mac address for ipv4 (currently it requires either name or ip but not both).