Re: [libvirt] [PATCH v2] qemu: Don't set address type too early during virtio disk hotplug

On 03/22/2013 06:52 PM, Guido Günther wrote: > f946462e14ac036357b7c11ce5c23f94a3ee4e49 changed behavior by settings > VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI upfront. If we do so before invoking > qemuDomainPCIAddressEnsureAddr we merely try to set the PCI slot via > qemuDomainPCIAddressReserveSlot instead reserving a new address via > qemuDomainPCIAddressSetNextAddr which fails with > > $ ~/run-tck-test domain/200-disk-hotplug.t > ./scripts/domain/200-disk-hotplug.t .. # Creating a new transient domain > ./scripts/domain/200-disk-hotplug.t .. 1/5 # Attaching the new disk /var/lib/jenkins/jobs/libvirt-tck-build/workspace/scratchdir/200-disk-hotplug/extra.img > > # Failed test 'disk has been attached' > # at ./scripts/domain/200-disk-hotplug.t line 67. > # died: Sys::Virt::Error (libvirt error code: 1, message: internal error unable to reserve PCI address 0:0:0.0 > # ) > --- > v2 merely fixes a typo in $subject. > -- Guido > > src/qemu/qemu_hotplug.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > ACK