Re: [libvirt] [PATCH v2 4/5] qemu: add virtio-gpu virgl support

On Wed, Nov 25, 2015 at 09:42:33AM +0100, Marc-André Lureau wrote: > Check if virtio-gpu provides virgl option, and add qemu command line > formatter. > > It is enabled with the existing accel3d attribute: > <model type='virtio' heads='1'> > <acceleration accel3d='yes'/> > </model> > > Signed-off-by: Marc-André Lureau <marcandre.lureau(a)gmail.com&gt; > --- > src/qemu/qemu_capabilities.c | 7 ++ > src/qemu/qemu_capabilities.h | 1 + > src/qemu/qemu_command.c | 17 +++- > tests/qemucapabilitiesdata/caps_1.2.2-1.replies | 22 +++-- > tests/qemucapabilitiesdata/caps_1.3.1-1.replies | 22 +++-- > tests/qemucapabilitiesdata/caps_1.4.2-1.replies | 22 +++-- > tests/qemucapabilitiesdata/caps_1.5.3-1.replies | 22 +++-- > tests/qemucapabilitiesdata/caps_1.6.0-1.replies | 22 +++-- > tests/qemucapabilitiesdata/caps_1.6.50-1.replies | 22 +++-- > tests/qemucapabilitiesdata/caps_2.1.1-1.replies | 22 +++-- > tests/qemucapabilitiesdata/caps_2.4.0-1.replies | 95 ++++++++++++++++++-- > tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + > tests/qemucapabilitiesdata/caps_2.5.0-1.replies | 100 +++++++++++++++++++-- > .../qemuxml2argv-video-virtio-gpu-virgl.args | 23 +++++ > .../qemuxml2argv-video-virtio-gpu-virgl.xml | 33 +++++++ > tests/qemuxml2argvtest.c | 4 + > tests/qemuxml2xmltest.c | 1 + > 17 files changed, 372 insertions(+), 64 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-virgl.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-virgl.xml > > diff --git a/tests/qemucapabilitiesdata/caps_2.5.0-1.caps b/tests/qemucapabilitiesdata/caps_2.5.0-1.caps > index 82b1df1..975ed0c 100644 > --- a/tests/qemucapabilitiesdata/caps_2.5.0-1.caps > +++ b/tests/qemucapabilitiesdata/caps_2.5.0-1.caps > @@ -163,4 +163,5 @@ > <flag name='virtio-net'/> > <flag name='incoming-defer'/> > <flag name='virtio-gpu'/> > + <flag name='virtio-gpu.virgl'/> > </qemuCaps> Even with current git: v2.5.0-rc2-4-g7144875 I am getting: # x86_64-softmmu/qemu-system-x86_64 -device virtio-gpu-pci,virgl=on qemu-system-x86_64: -device virtio-gpu-pci,virgl=on: Property '.virgl' not found