Re: [RFC PATCH 1/2] node_device_conf: virNodeDeviceGetSCSITargetCaps: fix memory leak
On Thu, Mar 28, 2024 at 03:55 PM +0100, Ján Tomko <jtomko(a)redhat.com> wrote:
On a Wednesday in 2024, Marc Hartmayer wrote:
>Make sure the old value in `scsi_target->wwpn` is free'd before replacing it.
>While at it, simplify the code.
>
"While at it" usually means it should have been a separate commit,
especially if the simplification changes the behavior of the code.
Looks like this patch has been merged:
5138dd247870 ("node_device_conf: virNodeDeviceGetSCSITargetCaps: fix
memory leak")
Shall we revert it and apply the patch in the mail “[PATCH v1]
node_device_conf: virNodeDeviceGetSCSITargetCaps: fix memory leak”
instead?
[…snip]
--
Kind regards / Beste Grüße
Marc Hartmayer
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294