Hi Dan,
On Fri, 2014-01-24 at 13:17 +0000, Daniel P. Berrange wrote:
This data format looks really very close to the .vmx file format.
The main difference I see is that the right hand side of the =
sign does not require quotes.
We already have a src/util/virconf.{c,h} module which was originally
designed to parse Xen's python-like config files. It was then extended
to cope with .vmx files. It seems like it should be easy to extend it
to handle the lxc file format too.
eg define a new VIR_CONF_FLAG_LXC_FORMAT flag for it parser to honour
Good to know... I wasn't aware of that. I'll have a look at it to share
as much code as possible.
> diff --git a/tests/lxcconf2xmldata/lxcconf2xml.fstab
b/tests/lxcconf2xmldata/lxcconf2xml.fstab
> new file mode 100644
> index 0000000..a08b2d6
> --- /dev/null
> +++ b/tests/lxcconf2xmldata/lxcconf2xml.fstab
> @@ -0,0 +1,3 @@
> +proc proc proc nodev,noexec,nosuid 0 0
> +sysfs sys sysfs defaults 0 0
> +tmpfs run tmpfs mode=0755,nodev,nosuid 0 0
Hmm, how are the fstab files handled ? The virConnectDomainNativeToXML
API only allows a single config file to be passed into ?
I assumed we could get the fstab file from the config file corresponding
entry. Of course for the unit tests I had to tweak that a bit. If we
can't assume fstab can be fetched, then what could we do?
--
Cedric