Re: [libvirt] [PATCH v2 2/3] libxl: implement virDomainPM* functions

On 09/06/2018 03:06 PM, Marek Marczykowski-Górecki wrote: A few additional comments came to mind while looking at this patch again...

> > > + /* Unlock virDomainObjPtr to not deadlock with even handler, which will try > > > + * to send lifecycle event > > > + */ > > > + virObjectUnlock(vm); > > > + ret = libxl_domain_suspend_only(cfg->ctx, vm->def->id, NULL); > > > + virObjectLock(vm); > > > + > > > + if (ret < 0) { > > > + virReportError(VIR_ERR_INTERNAL_ERROR, > > > + _("Failed to suspend domain '%d'"), vm->def->id); > > > + goto endjob; > > > + } > > > + Should we create a lifecycle event and/or call virDomainObjSetState on successful suspend? Seems neither are done in the qemu driver, but might be an oversight there too.