19/12/23 17:24, Peter Krempa пишет:
Multiplication results in integer overflow. Replace value of 6th agrument with ULLONG_MAX.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 04bd77a19f ("conf: Move and rename virDomainParseScaledValue()") The multiplication was there before this patch, since that's just moving
On Tue, Dec 19, 2023 at 14:27:11 +0300, Egor Makrushin wrote: the code. If you want to use the 'Fixes' tag make sure to find the commit that actually added the problem.
I can drop this tag if you want or you can find the proper commit. Thanks for the remark. I think it would be better to remove this tag, which I will do in the next version of the patch.
Signed-off-by: Egor Makrushin <emakrushin@astralinux.ru> --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 58a985fc5d..871fd3a874 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8523,7 +8523,7 @@ virDomainControllerDefParseXML(virDomainXMLOption *xmlopt, unsigned long long bytes; if ((rc = virParseScaledValue("./pcihole64", NULL, ctxt, &bytes, 1024, - 1024ULL * ULONG_MAX, false)) < 0) + ULLONG_MAX, false)) < 0) return NULL;
if (rc == 1) Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Egor Makrushin