Re: [libvirt] [PATCH 03/26] Remove pointless storage of var names in virNWFilterHashTable
On 04/08/2014 11:37 AM, Daniel P. Berrange wrote:
The virNWFilterHashTable struct contains a virHashTable and
then a 'char **names' field which keeps a copy of all the
hash keys. Presumably this was intended to record the ordering
of the hash keys. No code ever uses this and the ordering is
mangled whenever a variable is removed from the hash, because
the last element in the list is copied into the middle of the
list when shrinking the arra.
Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
ACK