Re: [PATCH 3/3] qemu: Implement the virDomainSetLaunchSecurityState API

On 12/3/21 08:10, Daniel P. Berrangé wrote: > On Tue, Nov 30, 2021 at 04:52:00PM -0700, Jim Fehlig wrote: > > Set a launch secret in guest memory using the sev-inject-launch-secret > > QMP API. Only supported for SEV-enabled guests. > > > > Signed-off-by: Jim Fehlig <jfehlig(a)suse.com&gt; > > --- > > src/qemu/qemu_driver.c | 78 ++++++++++++++++++++++++++++++++++++ > > src/qemu/qemu_monitor.c | 12 ++++++ > > src/qemu/qemu_monitor.h | 6 +++ > > src/qemu/qemu_monitor_json.c | 34 ++++++++++++++++ > > src/qemu/qemu_monitor_json.h | 5 +++ > > 5 files changed, 135 insertions(+) > > > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > > index 4e680bc0a7..b6ee41b29e 100644 > > --- a/src/qemu/qemu_driver.c > > +++ b/src/qemu/qemu_driver.c > > @@ -20056,6 +20056,83 @@ qemuDomainGetLaunchSecurityInfo(virDomainPtr domain, > > return ret; > > } > > + > > +static int > > +qemuDomainSetLaunchSecurityState(virDomainPtr domain, > > + virTypedParameterPtr params, > > + int nparams, > > + unsigned int flags) > > +{ > > + virQEMUDriver *driver = domain->conn->privateData; > > + virDomainObj *vm; > > + int ret = -1; > > + size_t i; > > + g_autofree char *secrethdr = NULL; > > + g_autofree char *secret = NULL; > > + long long setaddr = -1; > > unsigned, but would need to defaut to 0 then i guess. As Peter mentioned, 0 may be a valid injection address https://listman.redhat.com/archives/libvir-list/2021-November/msg00463.html The address in optional in the qemu API, in which case it is retrieved from ovmf IIUC. I used a signed variable here to distinguish between user not providing an address and providing one, including a valid value of 0.