Re: [libvirt PATCH 2/2] meson: Add tests_timeout build option

On Wed, 2020-09-09 at 14:41 +0100, Daniel P. Berrangé wrote: > On Wed, Sep 09, 2020 at 03:38:21PM +0200, Pavel Hrdina wrote: > > On Wed, Sep 09, 2020 at 02:31:48PM +0100, Daniel P. Berrangé wrote: > > > Does Meson not have a standard way to increase the default > > > timeout globally ? It feels like this scenario of building > > > on slow hardware could hit any application, so surprised > > > we need to add our own args for this > > > > It does but only if using meson command: > > > > meson test -t > > > > if the tests are started using ninja command: > > > > ninja test > > > > it is not possible to pass additional arguments to meson via ninja. > > So unless there's a blocker preventing use of "meson test -t" then > it seems we don't need this patch. Fedora seems to be using 'meson test' already; Debian uses 'ninja test' in debhelper compat level 12 but switched to 'meson test' with level 13, which doesn't look problematic otherwise and I should be able to adopt pretty quickly. I'm not sure about other distributions out there. Taking a step back, what are the reasons one might want to call either meson or ninja to run the test suite?