Re: [libvirt PATCH 2/2] meson: Add tests_timeout build option
On Wed, 2020-09-09 at 14:31 +0100, Daniel P. Berrangé wrote:
On Wed, Sep 09, 2020 at 03:10:06PM +0200, Andrea Bolognani wrote:
> The default timeout for tests is 30s, but that's not always
> enough time: the Valgrind test, for example, are currently
> special-cased because they take longer, and on certain
> architectures where powerful hardware is not (yet) available
> even the basic test programs might take more than 30s to
> complete.
Does Meson not have a standard way to increase the default
timeout globally ? It feels like this scenario of building
on slow hardware could hit any application, so surprised
we need to add our own args for this
Not that I could find... To be honest, some parts of Meson and Ninja
are documented in a way that is not immediately obvious to me, so I
might very well have missed it.
Note that 'meson test' supports
-t TIMEOUT_MULTIPLIER
--timeout-multiplier TIMEOUT_MULTIPLIER
Define a multiplier for test timeout, for example when running
tests in particular conditions they might take more time to
execute.
but there doesn't seem to be a 'ninja test' equivalent; I'm also
unclear on how a multiplier passed this way would interact with
timeout_multiplier as provided to add_test_setup() calls, which is
something that we use for Valgrind.
--
Andrea Bolognani / Red Hat / Virtualization