Re: [libvirt] [PATCH v2 05/10] conf: alter disk mirror xml output

On 06/06/2014 05:36 AM, Peter Krempa wrote: > On 06/06/14 00:52, Eric Blake wrote: >> Now that we track a disk mirror as a virStorageSource, we might >> as well update the XML to theoretically allow any type of >> mirroring destination (not just a local file). A later patch >> will also be reusing <mirror> to track the block commit of the >> top layer of a chain, which is another case where libvirt needs >> to update the backing chain after the job is finally pivoted, >> and since backing chains can have network backing files as the >> destination to commit into, it makes more sense to display that >> in the XML. >> > > ACK, I made a minor tweak (in virDomainDiskDefFormat, I split the initial <mirror type='...' ready='...'> into two actions, per your comment on 9/10), and pushed this one.