Re: [libvirt] [PATCH 07/10] Support virDomainOpenConsole with QEMU

> + for (i = 0 ; !chr && i < vm->def->nserials ; i++) { > + if (STREQ(devname, vm->def->serials[i]->info.alias)) > + chr = vm->def->serials[i]; > + } Are we guaranteed that all devices will have a non-NULL and unique alias,

> + if (!chr) { > + qemuReportError(VIR_ERR_INTERNAL_ERROR, > + _("cannot find character device %s"), devname); NULLSTR(devname) > + goto cleanup; > + } > + > + if (chr->type != VIR_DOMAIN_CHR_TYPE_PTY) { > + qemuReportError(VIR_ERR_INTERNAL_ERROR, > + _("character device %s is not using a PTY"), devname); NULLSTR(devname)